Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14946#discussion_r77561499
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
 ---
    @@ -263,8 +263,7 @@ class SessionCatalog(
               CatalogColumn(
                 name = c.name,
                 dataType = c.dataType.catalogString,
    -            nullable = c.nullable,
    -            comment = Option(c.name)
    --- End diff --
    
    Like the existing master build, we removed this useless `comment` 
attribute. The major reason is the [schema 
comparison](https://github.com/apache/spark/blob/6d86403d8b252776effcddd71338b4d21a224f9b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala#L163)
 also checks the comment. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to