Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14809#discussion_r77578688
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -272,17 +282,11 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
"Hive metastore in Spark SQL specific format, which is NOT
compatible with Hive. "
(None, message)
- case (Some(serde), Some(path)) =>
+ case Some(serde) =>
val message =
- s"Persisting file based data source table $qualifiedTableName
with an input path " +
- s"into Hive metastore in Hive compatible format."
- (Some(newHiveCompatibleMetastoreTable(serde, path)), message)
-
- case (Some(_), None) =>
- val message =
- s"Data source table $qualifiedTableName is not file based.
Persisting it into " +
- s"Hive metastore in Spark SQL specific format, which is NOT
compatible with Hive."
- (None, message)
+ s"Persisting file based data source table $qualifiedTableName
into " +
--- End diff --
only external table has path, and the previous code doesn't log the path
either.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
