Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14894
This is better. It looks like `DDLSuite` tests the default location which
is `./spark-warehouse` in "Create Database using Default Warehouse Path".
That's fine but it fails to clean up the directory. I think it needs to clean
up there too. You can see that elsewhere it uses this `withTempDir { tempDir
=>` idiom to correctly set this to a temp dir.
Although I agree with your changes, aren't there other places in the same
file that need the same treatment?
Ultimately the goal is to see that after a successful test run, no
`spark-warehouse` exists. If that's true then we can remove it from
`.gitignore` and `.rat-excludes`. CC @liancheng re:
https://github.com/apache/spark/commit/63db2bd283a430971d85f2a7b06dac77723c56fa
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
