GitHub user frreiss opened a pull request:
https://github.com/apache/spark/pull/14986
[WIP] [SPARK-17421] Don't use -XX:MaxPermSize option when Java version >= 8
## What changes were proposed in this pull request?
Modifies the `build/mvn` and `build/sbt-launch-lib.bash` scripts so that
they check the Java version and omit the `-XX:MaxPermSize=512M` option for Java
versions >= 8.
## How was this patch tested?
Ran the build on Linux and Mac with Java 7 and 8, from `build/mvn` and
`dev/run-tests`. Also tested Java 8 with `JAVA_7_HOME` pointing to a Java 7
installation.
Currently, `dev/run-tests` has a few remaining instances of the MaxPermSize
warning, apparently due to another code path to spawning a JVM. Keeping this PR
as a WIP until the output of `dev/run-tests` is completely clean.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/frreiss/spark-fred fred-17421
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14986.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14986
----
commit c9beadd02c22c7a84b521003fdebee0ba45bd286
Author: frreiss <frre...@us.ibm.com>
Date: 2016-09-06T22:19:44Z
Added logic to build/mvn to check Java version.
commit 0955947dcf83c90473f4f77b19a0559558bba80c
Author: frreiss <frre...@us.ibm.com>
Date: 2016-09-06T22:37:47Z
Made sbt-launch-lib.bash check for Java >7
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
