Github user clockfly commented on a diff in the pull request:
https://github.com/apache/spark/pull/14962#discussion_r77745578
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -72,9 +72,7 @@ class SessionCatalog(
this(externalCatalog, new SimpleFunctionRegistry, new
SimpleCatalystConf(true))
}
- /** List of temporary tables, mapping from table name to their logical
plan. */
- @GuardedBy("this")
- protected val tempTables = new mutable.HashMap[String, LogicalPlan]
+ private val tempViews = new TempViewManager
--- End diff --
Since the goal of this PR is to add some view related API. So I think
refactoring using TempViewManager is not the major goal?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
