Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14788 Looks pretty good. I left a few more comments. Could you also add a test for TruncDate that covers a day light saving scenario?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org