Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/12601
  
    @JustinPihony Based on my understanding, we need to minimize the code 
changes at our best. Any extra code changes might introduce unnecessary bugs. 
    
    At the same time, we need to improve the test coverage at our best. Please 
check my PR https://github.com/apache/spark/pull/14077 and add the test cases 
here, if possible.
    
    In the future, if we want to support user-defined schema, the work in this 
PR is not enough. Again, the test coverage is very very important when we 
intially add the code. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to