Github user dhruve commented on a diff in the pull request:
https://github.com/apache/spark/pull/14926#discussion_r78092320
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -392,10 +397,36 @@ private[spark] class ExecutorAllocationManager(
}
/**
- * Request the cluster manager to remove the given executor.
+ * Request the cluster manager to remove the given executors.
* Return whether the request is received.
*/
- private def removeExecutor(executorId: String): Boolean = synchronized {
+ private def removeExecutors(executorIds: Seq[String]): Boolean =
synchronized {
+
+ val executorIdsToBeRemoved = executorIds.filter(canBeKilled)
+
+ // Send a request to the backend to kill this executor
+ val removeRequestAcknowledged = testing ||
client.killExecutors(executorIdsToBeRemoved)
--- End diff --
@vanzin
We can do the following:
* Get ```SparkContext``` rid of the ```ExecutorAllocationClient```
* ```SparkContext``` still exposes the killExecutor(s)
* Change ```ExecutorAllocationClient``` to return a list of filtered
executors which were requested to be killed.
The current dev api for ```killExecutors``` returns a boolean. How do we
want to interpret this. Because the ```CoarseGrainedSchedulerBackend``` can
decide to kill a subset of the requested executors, so how do we interpret
this? Killing any one of them should return true or killing all of them? The
semantics are kind of hazy here.
Can we change the api to return the list of killed executors making it
consistent throughout? Or keep the api the same but have not very clear
understanding.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
