Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78104785
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -232,6 +363,47 @@ class LogisticRegressionSuite
}
}
+ test("coefficients and intercept methods") {
+ val mlr = new LogisticRegression().setMaxIter(1)
+ val mlrModel = mlr.fit(smallMultinomialDataset)
+ val thrownCoef = intercept[SparkException] {
+ mlrModel.coefficients
+ }
+ val thrownIntercept = intercept[SparkException] {
+ mlrModel.intercept
+ }
+ assert(thrownCoef.getMessage().contains("use coefficientMatrix
instead"))
+ assert(thrownIntercept.getMessage().contains("use interceptVector
instead"))
+
+ val blr = new LogisticRegression().setMaxIter(1)
--- End diff --
In tests like these, perhaps we should explicitly set the family to be
certain of the code path. We already have a test to check the family detection
code. I'll add this in my next commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
