GitHub user ScrapCodes opened a pull request:

    https://github.com/apache/spark/pull/2079

    [SPARK-2988] - Port repl to scala 2.11.

    Why do we need to port the repl for scala 2.11, especially when scala repl 
has class based wrappers ?
    
    We need to do this, because they are not sufficient for our needs. Also 
scala repl does not allow us to plugin our own wrappers and access mechanism. 
Because most of the things in repl are private and can not be inherited. So 
only choice left was to copy the code in to our code base and make adjustments. 
The reason class based wrappers are not sufficient is in short "directly 
importing the created objects by import wrappers results in recreation on 
remote nodes". So we import by first referring to them as `INSTANCE` in the 
object. Please take a look at the patch for more details.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ScrapCodes/spark-1 repl-port

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/2079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2079
    
----
commit b1a40215b6de41f2da0915c528e4f82f81657f53
Author: Prashant Sharma <prashan...@imaginea.com>
Date:   2014-08-12T10:55:57Z

    Adjust build system and tests to work with scala 2.11

commit 645a5b764d9dd084474af5b9dae3289176f5e80e
Author: Prashant Sharma <prashan...@imaginea.com>
Date:   2014-08-20T12:48:15Z

    Few more fixes/ improvements to jenkins build.

commit d12ae04d9b626c46ebe53e02cf796fd65b9cb42c
Author: Prashant Sharma <prashan...@imaginea.com>
Date:   2014-08-21T07:22:19Z

    Added ported scala repl for scala 2.11

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to