Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/15036#discussion_r78256795
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -807,8 +801,8 @@ private[spark] class BlockManager(
// Now that the block is in either the memory or disk store,
// tell the master about it.
info.size = size
- if (tellMaster) {
- reportBlockStatus(blockId, info, putBlockStatus)
+ if (tellMaster && info.tellMaster) {
--- End diff --
This is a bit confusing. What is the difference between tellMaster and
info.tellMaster ? For instance, why isn't this tellMaster || info.tellMaster.
(I understand that && is the current behavior, but I'm not sure why.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
