Github user saturday-shi commented on the issue:

    https://github.com/apache/spark/pull/15022
  
    Thank @JoshRosen for your reply!
    
    > Actually, I spot one more step to make this really robust: I think we 
also need to call `releasePendingUnrollMemoryForThisTask` at the end of Task in 
order to be absolutely sure this memory will be released during error cases.
    
    That's right. I will make the change later.
    And it is really helpful if you have an good idea of adding a test to avoid 
regressing. I just worrying about that I don't have an easy way to check if the 
problem relapsed or not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to