Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15048#discussion_r78331097 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala --- @@ -68,7 +68,7 @@ class ResolveDataSource(sparkSession: SparkSession) extends Rule[LogicalPlan] { /** * Preprocess some DDL plans, e.g. [[CreateTable]], to do some normalization and checking. --- End diff -- we should update the comments to say that this rule will also analyze the query.(we may also wanna update the rule name)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org