Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r78378090
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -157,9 +177,15 @@ public void run() {
* Creates a new app handle. The handle will wait for an incoming
connection for a configurable
* amount of time, and if one doesn't arrive, it will transition to an
error state.
*/
- ChildProcAppHandle newAppHandle(String secret) {
- ChildProcAppHandle handle = new ChildProcAppHandle(secret, this);
- ChildProcAppHandle existing = pending.putIfAbsent(secret, handle);
+ AbstractSparkAppHandle newAppHandle(String secret, boolean
isThreadHandle) {
+
+ AbstractSparkAppHandle handle;
+ if(isThreadHandle) {
--- End diff --
space after if
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
