Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15009#discussion_r78387176
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
    @@ -73,6 +74,21 @@
       /** Logger name to use when launching a child process. */
       public static final String CHILD_PROCESS_LOGGER_NAME = 
"spark.launcher.childProcLoggerName";
     
    +  /** Launcher Server Port to use when launching a child process. */
    +  public static final String LAUNCHER_INTERNAL_PORT = 
"spark.launcher.internal.port";
    --- End diff --
    
    these shouldn't be public


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to