Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15060#discussion_r78408999
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala ---
    @@ -395,6 +395,14 @@ private[ann] class FeedForwardTopology private(val 
layers: Array[Layer]) extends
       override def model(weights: Vector): TopologyModel = 
FeedForwardModel(this, weights)
     
       override def model(seed: Long): TopologyModel = FeedForwardModel(this, 
seed)
    +
    +  def weightSize: Int = {
    --- End diff --
    
    Just `layers.map(_.weightSize).sum`? You don't even need a method really.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to