Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15063#discussion_r78432833
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/debug/package.scala ---
@@ -107,18 +109,20 @@ package object debug {
case class DebugExec(child: SparkPlan) extends UnaryExecNode with
CodegenSupport {
def output: Seq[Attribute] = child.output
- class SetAccumulator[T] extends AccumulatorV2[T, HashSet[T]] {
- private val _set = new HashSet[T]()
+ class SetAccumulator[T] extends AccumulatorV2[T, java.util.Set[T]] {
+ private val _set = Collections.synchronizedSet(new
java.util.HashSet[T]())
--- End diff --
If you use `Collections.synchronized*`, will serialization of those objects
also be thread-safe (i.e. will `writeObject` synchronize properly)? What about
if Kryo is used?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
