Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13642#discussion_r78450919
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
 ---
    @@ -17,48 +17,18 @@
     
     package org.apache.spark.sql.execution.metric
     
    -import java.io.{ByteArrayInputStream, ByteArrayOutputStream}
    -
    -import scala.collection.mutable
    -
    -import org.apache.xbean.asm5._
    -import org.apache.xbean.asm5.Opcodes._
    -
     import org.apache.spark.SparkFunSuite
     import org.apache.spark.sql._
     import org.apache.spark.sql.execution.SparkPlanInfo
     import org.apache.spark.sql.execution.ui.SparkPlanGraph
     import org.apache.spark.sql.functions._
     import org.apache.spark.sql.internal.SQLConf
     import org.apache.spark.sql.test.SharedSQLContext
    -import org.apache.spark.util.{AccumulatorContext, JsonProtocol, Utils}
    -
    +import org.apache.spark.util.{AccumulatorContext, JsonProtocol}
     
     class SQLMetricsSuite extends SparkFunSuite with SharedSQLContext {
       import testImplicits._
     
    -  test("SQLMetric should not box Long") {
    --- End diff --
    
    Why remove this test? This test doesn't use the old accumulator API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to