Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15068#discussion_r78481314
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -2567,8 +2567,12 @@ class Dataset[T] private[sql](
}
private[sql] def collectToPython(): Int = {
+ EvaluatePython.registerPicklers()
withNewExecutionId {
- PythonRDD.collectAndServe(javaToPython.rdd)
--- End diff --
Note that `collectAndServe` was internally calling
`rdd.collect().iterator`, so this patch's change doesn't have any impact on the
maximum number of rows that need to be buffered in the JVM; this would not have
been the case if the old code used `collectAndServeIterator`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
