Github user vlad17 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14547#discussion_r78483380
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/DTStatsAggregator.scala ---
@@ -33,11 +34,13 @@ private[spark] class DTStatsAggregator(
/**
* [[ImpurityAggregator]] instance specifying the impurity type.
- */
- val impurityAggregator: ImpurityAggregator = metadata.impurity match {
+ */
+ private val impurityAggregator: ImpurityAggregator = metadata.impurity
match {
+ // TODO(vlad17): this is a ridiculous coupling. Impurity should have a
getAggregator() method
--- End diff --
Updated https://issues.apache.org/jira/browse/SPARK-16728
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
