Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/14912
  
    ping @srinathshankar @cloud-fan @hvanhovell Can you help review this change?
    
    Some context here:
    
    Some predicates are unable to push down because:
    
    1. Predicates are simplified to the form which is not able to push down
    
    `Filter` can't push down through `Filter`. So the predicates in `Filter` 
will be simplified to the form unable to push down in next optimizing round. 
This is this change wants to fix. This change triggers `PushdownPredicate` in 
`CombineFilters`. So combined predicates can be pushed down before 
`BooleanSimplification` rule.
    
    2. Predicates are in the form unable to push down at the beginning
    
    We may need to come out an approach to maintain multiple forms of 
predicates which at least can benefit pushdown and expression simplification. 
This will leave to later PRs. Need more discussion.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to