Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/14601#discussion_r78520985
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala
---
@@ -102,11 +102,20 @@ class SparkHadoopUtil extends Logging {
hadoopConf.set("fs.s3n.awsSecretAccessKey", accessKey)
hadoopConf.set("fs.s3a.secret.key", accessKey)
}
- // Copy any "spark.hadoop.foo=bar" system properties into conf as
"foo=bar"
conf.getAll.foreach { case (key, value) =>
+ // Copy any "spark.hadoop.foo=bar" system properties into conf as
"foo=bar"
if (key.startsWith("spark.hadoop.")) {
hadoopConf.set(key.substring("spark.hadoop.".length), value)
}
+ // fix added for SPARK-13979
+ // Copy any "fs.swift2d.foo=bar" or "fs.swift.foo=bar" properties into
conf
+ else if (key.startsWith("fs.swift")){
+ hadoopConf.set(key, value)
+ }
+ // Copy any "fs.s3.foo=bar" or "fs.s3a.foo=bar" or
"fs.s3n.foo=bar" properties into conf
+ else if (key.startsWith("fs.s3")){
+ hadoopConf.set(key, value)
+ }
--- End diff --
s3 is the AWS EMR filesystem, but an obsolete one on ASF Hadoop. I would
recommend the list of
s3, s3n, s3a, swift, azure, wasb, oss, gcs
azure is in hadoop 2.7, wasb and oss will be in hadoop 3, gcs is google's
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
