Github user srinathshankar commented on a diff in the pull request:
https://github.com/apache/spark/pull/15043#discussion_r78645978
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -782,6 +785,9 @@ private[storage] class PartiallySerializedBlock[T](
* `close()` on it to free its resources.
*/
def valuesIterator: PartiallyUnrolledIterator[T] = {
+ // Close the serialization stream so that the serializer's internal
buffers are freed and any
+ // "end-of-stream" markers can be written out so that `unrolled` is a
valid serialized stream.
+ serializationStream.close()
--- End diff --
It seems like 'unrolled' may basically be invalid until serializationStream
is called.
But it looks like valuesIterator is not the only place where unrolled is
used
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
