Github user srinathshankar commented on a diff in the pull request: https://github.com/apache/spark/pull/15085#discussion_r78660620 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala --- @@ -857,9 +862,11 @@ private[spark] class BlockManager( val startTimeMs = System.currentTimeMillis var blockWasSuccessfullyStored: Boolean = false + var exceptionWasThrown: Boolean = true val result: Option[T] = try { val res = putBody(putBlockInfo) blockWasSuccessfullyStored = res.isEmpty + exceptionWasThrown = false res } finally { if (blockWasSuccessfullyStored) { --- End diff -- Wouldn't blockWasSuccessfullyStored be false if exceptionWasThrown were true ? In that case, couldn't we write this as try { ... } catch (Exception e) { removeBlock addUpdatedBlock } finally { // WHatever was there before ? }
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org