Github user eyalfa commented on the issue:

    https://github.com/apache/spark/pull/14444
  
    @HyukjinKwon, thank you very much for your analysis.
    if you read the history of this PR you'd see that at some point @hvanhovell 
suggested that we completely remove CreateStruct and CreateStructUnsafe and 
just leave a constructor that create the named version.
    I've modified catalyst tests that relied on CreateStruct, so I guess R 
tests should be modified as well.
    
    One thing I don't really understand, which is probably related to my 
(complete) lack of R knowledge:
    in scala API collect returns rows, what does it return in R, what does the 
'named_struct(...)' come from? is it the column name in the schema?
    
    @hvanhovell: how strong is the contract of assigning a name to an unnamed 
column? should we alias the constructed tree with the backward compatible name? 
(when creating the named struct)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to