Github user clockfly commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15099#discussion_r79126355
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
 ---
    @@ -140,7 +146,9 @@ case class CreateDataSourceTableAsSelectCommand(
     
         var createMetastoreTable = false
         var existingSchema = Option.empty[StructType]
    -    if (sparkSession.sessionState.catalog.tableExists(table.identifier)) {
    +    // Pass a table identifier with database part, so that `tableExists` 
won't check temp views
    +    // unexpectedly.
    +    if (sparkSession.sessionState.catalog.tableExists(tableIdentWithDB)) {
    --- End diff --
    
    For 
    ```
    // Pass a table identifier with database part, so that `tableExists` won't 
check temp views
    ```
    
    This is kind of hack to me. Do you have ways to avoid hacking table 
identifier?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to