Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2076#discussion_r16628889
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/storage/StorageTab.scala 
---
    @@ -73,8 +73,9 @@ class StorageListener(storageStatusListener: 
StorageStatusListener) extends Spar
       }
     
       override def onStageCompleted(stageCompleted: 
SparkListenerStageCompleted) = synchronized {
    -    // Remove all partitions that are no longer cached
    -    _rddInfoMap.retain { case (_, info) => info.numCachedPartitions > 0 }
    +    // Remove all partitions that are no longer cached in current 
completed stage
    +    val comletedRddIds = Set(stageCompleted.stageInfo.rddInfos.map(r => 
r.id))
    +    _rddInfoMap.retain { case (id, info) => !comletedRddIds.contains(id) 
|| info.numCachedPartitions > 0 }
    --- End diff --
    
    Could you describe in more detail the sequence that can cause this issue? 
Better yet, maybe write a unit test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to