Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/15123#discussion_r79274396
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -325,6 +325,24 @@ class DataFrameSuite extends QueryTest with
SharedSQLContext {
Row(6))
}
+ test("sorting with null ordering") {
+ val data = Seq[java.lang.Integer](2, 1, null).toDF("key")
--- End diff --
Thanks for the cleanup and refining the test case! For the test case with 2
column data, I was thinking to create a bit more complex ordering to utilize
the prefix sort and regular `GenerateOrdering` in one query. But it is not
necessary since the major PR for SQL interface has include such scenario.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
