Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15054#discussion_r79528505
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
 ---
    @@ -357,6 +346,21 @@ class SessionCatalog(
         tempTables.remove(formatTableName(name))
       }
     
    +  /**
    +   * Retrieve the metadata of an existing temporary view.
    +   * If the temporary view does not exist, return None.
    +   */
    +  def getTempViewMetadataOption(name: String): Option[CatalogTable] = 
synchronized {
    --- End diff --
    
    Seems we always use it with the pattern 
`getTempViewMetadataOption.getOrElse(getTableMetadata)`, maybe we should just 
rename it to `getTempViewOrPermanentTableMetadata`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to