Github user viirya commented on the issue:
https://github.com/apache/spark/pull/14452
@davies Thanks for comment.
In our initial benchmark of the TPC-DS queries (totally 13) using CTE, this
PR helps about half (6) of them, 5 queries are not affected, 2 queries are
regressed. I might say it would help CTE queries at most cases according to the
results.
I agree that 500+ LOC changes looks a bit big for this improvement. I would
like to refactor and tailor part of the changes and break it down to small
pieces for you to review. I wish I can reduce the LOC changes at the end.
I would like to run Q64 by disabling the push down, may I ask the purpose
for it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
