Github user Sherry302 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14659#discussion_r79692046
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
    @@ -54,7 +54,10 @@ private[spark] abstract class Task[T](
         val partitionId: Int,
         // The default value is only used in tests.
         val metrics: TaskMetrics = TaskMetrics.registered,
    -    @transient var localProperties: Properties = new Properties) extends 
Serializable {
    +    @transient var localProperties: Properties = new Properties,
    +    val jobId: Option[Int] = None,
    --- End diff --
    
    Making these params all optional is not to break current code which uses 
this API. An alternative way is to mark the current API as deprecated and add a 
new overloaded function with new parameters. I am going to go this way. Any 
suggestions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to