Github user koeninger commented on the issue: https://github.com/apache/spark/pull/15102 @tdas I think as long as marmbrus' PR to remove comparable from the interface works for sane variations of subscription changes it's the best way to go. I'm honestly fine with someone getting what they deserve if they delete and recreate a topic in the space of a single batch or while a stream is down. @marmbrus > Why do you care when it acquired it? This isn't so much a temporal thing, as a let the consumer do its job thing. This sort of configuration should ideally be handled by auto.offset.reset, and we shouldn't bake in too much second guessing about it. There's plenty of use case for "I want to be able to add a topicpartition mid stream, but I don't want to start it from the beginning." > Are you proposing users have to type I'm saying that you guys proposed json as a workaround for the string->string thing. Given that, yeah, I think consistency in using json for any non-scalar values is worth 2 extra characters per topic and 4 at the ends.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org