Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/14035
@HyukjinKwon I have made a pass and this PR look good overall. Could you
double check whether all ML test cases are covered? Since I found we used
implicit import of different style at
[```ChiSqSelectorSuite```](https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/ml/feature/ChiSqSelectorSuite.scala#L33),
it's better we can unify them. Then I'd like to get this in. Thanks for
working on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
