Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15214
@srowen @mpjlu
Another important reason for this change: it's error prone for Python ML
API.
```
def __init__(self, numTopFeatures=50, featuresCol="features",
outputCol=None,
labelCol="label", selectorType="kbest", percentile=0.1,
alpha=0.05):
......
def setParams(self, numTopFeatures=50, featuresCol="features",
outputCol=None,
labelCol="labels", selectorType="kbest",
percentile=0.1, alpha=0.05):
......
```
If users are not very familiar with ```ChiSqSelector```, they are likely to
set all parameters following the API docs. The output model is also relevant
with the arguments order. Users not aware of the order of arguments for the
Python API is a very strong possibility. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
