Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/15245#discussion_r80567995 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/RecordReaderIterator.scala --- @@ -52,4 +55,18 @@ class RecordReaderIterator[T](rowReader: RecordReader[_, T]) extends Iterator[T] havePair = false rowReader.getCurrentValue } + + override def close(): Unit = { + if (rowReader != null) { + try { + // Close the reader and release it. Note: it's very important that we don't close the --- End diff -- This comment is copied from `NewHadoopRdd`, which contains similar defensive programming.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org