Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/15231#discussion_r80594580
--- Diff: R/pkg/R/utils.R ---
@@ -698,6 +698,21 @@ isSparkRShell <- function() {
grepl(".*shell\\.R$", Sys.getenv("R_PROFILE_USER"), perl = TRUE)
}
+captureJVMException <- function(e) {
+ stacktrace <- as.character(e)
+ if (any(grep("java.lang.IllegalArgumentException: ", stacktrace))) {
--- End diff --
Ah, I see. Yeap. This might be about best effort thing. I think I tried (if
I am right) all combinations of parameters mssing/wrong in the APIs. One
exceptional case for both APIs is, they throw an exception,
`ClassCastException` when the extra options are wrongly typed, which I think we
should check within R side and this will be handled in
https://github.com/apache/spark/pull/15239
I might better open another PR for validating parameters across SparkR if
you think it is okay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
