Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15047#discussion_r80814832
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -276,6 +276,97 @@ abstract class HashExpression[E] extends Expression {
}
}
+ protected def genHashInt(i: String, hasher: String, result: String):
String =
--- End diff --
The hasher should be a static class. Show we don't really need to pass it
around. We could use `hasherClassName` instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
