Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15213#discussion_r80845459
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -2105,6 +2107,59 @@ class DAGSchedulerSuite extends SparkFunSuite with
LocalSparkContext with Timeou
assert(scheduler.getShuffleDependencies(rddE) === Set(shuffleDepA,
shuffleDepC))
}
+ test("After one stage is aborted for too many failed attempts,
subsequent stages" +
+ "still behave correctly on fetch failures") {
+ def fetchFailJob: Unit = {
--- End diff --
to make this a little more descriptive / easy to read, how about calling
the helper "runJobWithPersistentFetchFailure" and then add a comment that says
"Runs a job that always encounters a fetch failure, so should eventually be
aborted."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
