Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/15249#discussion_r81035029
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -478,8 +473,8 @@ private[spark] class TaskSetManager(
// a good proxy to task serialization time.
// val timeTaken = clock.getTime() - startTime
val taskName = s"task ${info.id} in stage ${taskSet.id}"
- logInfo(s"Starting $taskName (TID $taskId, $host, partition
${task.partitionId}," +
- s" $taskLocality, ${serializedTask.limit} bytes)")
+ logInfo(s"Starting $taskName (TID $taskId, $host, executor
${info.executorId}, " +
+ s"partition ${task.partitionId}, $taskLocality,
${serializedTask.limit} bytes)")
sched.dagScheduler.taskStarted(task, info)
return Some(new TaskDescription(taskId = taskId, attemptNumber =
attemptNum, execId,
--- End diff --
Not part of your code, but I'm not seeing a good reason for the non-local
return here. The last lines of `resourceOffer` can just as easily be...
```scala
sched.dagScheduler.taskStarted(task, info)
Some(new TaskDescription(taskId = taskId, attemptNumber =
attemptNum, execId,
taskName, index, serializedTask))
case _ => None
}
} else None
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
