GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/15292
[SPARK-17719][SQL] Unify and tie up options in a single place in JDBC
datasource package
## What changes were proposed in this pull request?
This PR proposes to fix arbitrary usages among `Map[String, String]`,
`Properties` and `JDBCOptions` instances in `execution/jdbc` package.
This PR includes some changes as below:
- Unify `Map[String, String]`, `Properties` and `JDBCOptions` in
`execution/jdbc` package to `JDBCOptions`.
- Move `batchsize`, `fetchszie`, `driver` and `isolationlevel` options into
`JDBCOptions` instance.
- Document `batchSize` and `isolationlevel` with marking both read-only
options and write-only options.
- Throw exceptions fast by checking arguments first rather than in
execution time (e.g. for `fetchsize`.
## How was this patch tested?
Existing tests should cover this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark SPARK-17719
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15292
----
commit 53b2c3d86a4daec3fbd74a4d7b4da0737231ab6b
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-09-29T04:51:04Z
Unify and tie up options in a single place in JDBC datasource API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
