Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2082#discussion_r16691419
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala
 ---
    @@ -101,3 +101,44 @@ case class GetField(child: Expression, fieldName: 
String) extends UnaryExpressio
     
       override def toString = s"$child.$fieldName"
     }
    +
    +/**
    + * Returns the value of fields[] in the Struct `child`.
    + * for array of structs
    + */
    +
    +case class GetArrayField(child: Expression, fieldName: String) extends 
UnaryExpression {
    +  type EvaluatedType = Any
    +
    +  def dataType = field.dataType
    +  override def nullable = child.nullable || field.nullable
    +  override def foldable = child.foldable
    +
    +  protected def arrayType = child.dataType match {
    +    case s: ArrayType => s.elementType match {
    --- End diff --
    
    this could be written as:
    
    ```scala
    child.dataType match {
      case ArrayType(s: StructType, _) => s
      case otherType => sys.error(s"GetArrayField is not valid on fields of 
type $otherType")
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to