Github user jodersky commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15257#discussion_r81207545
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
 ---
    @@ -60,6 +70,45 @@ object Literal {
       }
     
       /**
    +   * Returns the Spark SQL DataType for a given class object. Since this 
type needs to be resolved
    +   * in runtime, we use match-case idioms for class objects here. However, 
there are similar
    +   * functions in other files (e.g., HiveInspectors), so these functions 
need to merged into one.
    +   */
    +  private[this] def componentTypeToDataType(clz: Class[_]): DataType = clz 
match {
    +    // primitive types
    +    case c: Class[_] if c == jShort.TYPE => ShortType
    --- End diff --
    
    Here is an example:
    ```scala
      case object container {def value: Int = 42}
      case object Container {def value: Int = 42}
    
      def extract(wrapper: Any) = wrapper match {
        case container => container.value // error: value "value" is not a 
member of Any
        case Container => Container.value // ok
      }
    ```
    It's not a very good example, maybe something like 
http://stackoverflow.com/a/6576663/917519 will give you a better use-case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to