Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15053
@mortada I see. Then,
- It'd not almost increase the test time.
- It will improve the documentation.
- We have a reference for this, `numpy`
Therefore, +1 for each docstring within each method. Can we remove the
dataframes in `globs` and then do the same thing across PySpark documentation?
I just took a quicky look and it seems we have more instances such as ..
```
$ grep -r "globs\['df" .
./pyspark/sql/column.py: globs['df'] = sc.parallelize([(2, 'Alice'), (5,
'Bob')]) \
./pyspark/sql/context.py: globs['df'] = rdd.toDF()
./pyspark/sql/dataframe.py: globs['df'] = sc.parallelize([(2, 'Alice'),
(5, 'Bob')])\
./pyspark/sql/dataframe.py: globs['df2'] =
sc.parallelize([Row(name='Tom', height=80), Row(name='Bob', height=85)]).toDF()
./pyspark/sql/dataframe.py: globs['df3'] =
sc.parallelize([Row(name='Alice', age=2),
./pyspark/sql/dataframe.py: globs['df4'] =
sc.parallelize([Row(name='Alice', age=10, height=80),
./pyspark/sql/functions.py: globs['df'] =
sc.parallelize([Row(name='Alice', age=2), Row(name='Bob', age=5)]).toDF()
./pyspark/sql/group.py: globs['df'] = sc.parallelize([(2, 'Alice'), (5,
'Bob')]) \
./pyspark/sql/group.py: globs['df3'] = sc.parallelize([Row(name='Alice',
age=2, height=80),
./pyspark/sql/group.py: globs['df4'] =
sc.parallelize([Row(course="dotNET", year=2012, earnings=10000),
./pyspark/sql/readwriter.py: globs['df'] =
spark.read.parquet('python/test_support/sql/parquet_partitioned')
./pyspark/sql/session.py: globs['df'] = rdd.toDF()
./pyspark/sql/streaming.py: globs['df'] = \
```
Also, I think we'd better have a JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
