Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15276#discussion_r81274571
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -906,7 +906,7 @@ case class AssertNotNull(child: Expression,
walkedTypePath: Seq[String])
override protected def doGenCode(ctx: CodegenContext, ev: ExprCode):
ExprCode = {
val childGen = child.genCode(ctx)
- val errMsgField = ctx.addReferenceObj("errMsg", errMsg)
+ val errMsgField = ctx.addReferenceObj(errMsg)
--- End diff --
thanks - then i'd actually add a comment in the caller indicating it is
important to call the variant that doesn't create a local field.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
