Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15249#discussion_r81410776
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/SchedulerIntegrationSuite.scala
---
@@ -634,8 +643,14 @@ class BasicSchedulerIntegrationSuite extends
SchedulerIntegrationSuite[SingleCor
val jobFuture = submit(new MockRDD(sc, 10, Nil), (0 until
10).toArray)
val duration = Duration(1, SECONDS)
awaitJobTermination(jobFuture, duration)
- failure.getMessage.contains("test task failure")
+ assert(failure.getMessage.contains("test task failure"))
}
assertDataStructuresEmpty(noFailure = false)
}
+
+ def testNoBlacklist(name: String)(body: => Unit): Unit = {
+ // in these simple tests, we only have one executor, so it doens't
make sense to turn on the
+ // blacklist. Just an artifact of this simple test-framework still
kinda acting like local-mode
--- End diff --
this second sentence is hard to parse -- just delete it? Also any reason
not to make all of the tests here not use the blacklist (and then you don't
need this special function)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
