GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/15320

    [SPARK-14914][CORE][SQL] Skip/fix some test cases on Windows due to 
limitation of Windows

    ## What changes were proposed in this pull request?
    
    This PR proposes to fix/skip some tests failed on Windows. This PR takes 
over https://github.com/apache/spark/pull/12696.
    
    ## How was this patch tested?
    
    Manually tested.
    
    **SparkSubmitSuite**
    
    ```
    [info] - launch simple application with spark-submit *** FAILED *** (202 
milliseconds)
    [info]   java.io.IOException: Cannot run program "./bin/spark-submit" (in 
directory "C:\projects\spark"): CreateProcess error=2, The system cannot find 
the file specifie
    
    [info] - includes jars passed in through --jars *** FAILED *** (1 second, 
625 milliseconds)
    [info]   java.io.IOException: Cannot run program "./bin/spark-submit" (in 
directory "C:\projects\spark"): CreateProcess error=2, The system cannot find 
the file specified
    
    [info] - includes jars passed in through --packages *** FAILED *** (78 
milliseconds)
    [info]   java.lang.IllegalArgumentException: Illegal character in path at 
index 12: 
string:///C:\projects\spark\target\tmp\1475306700486-0\1982582003\MyLib.jav
    ```
    
    **DiskStoreSuite**
    
    ```
    [info] - reads of memory-mapped and non memory-mapped files are equivalent 
*** FAILED *** (1 second, 78 milliseconds)
    [info]   diskStoreMapped.remove(blockId) was false (DiskStoreSuite.scala:41)
    ```
    
    For `CreateTableAsSelectSuite` and `FsHistoryProviderSuite`, I could not 
reproduce as the Java version seems higher than the one that has the bugs about 
`setReadable(..)` and `setWritable(...)` but as they are bugs reported clearly, 
it'd be sensible to skip those. We should revert the changes for both back as 
soon as we drop the support of Java 7.
    
    Closes #12696

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark SPARK-14914

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15320
    
----
commit 0dd55dbc1693d8e7f5657fe2e235b7315ee2067b
Author: U-FAREAST\tl <[email protected]>
Date:   2016-04-25T07:43:32Z

    Select correct spark submit and a test case can't work on windows for 
FsHistoryProviderSuite

commit d50b1b0adf2f9d3c8926775180280796c67bd632
Author: Tao LI <[email protected]>
Date:   2016-04-25T08:10:00Z

    Circular buffer on windows.

commit cebc6884d392e36c4d727b6ecf61d96289d22c33
Author: Tao LI <[email protected]>
Date:   2016-04-25T08:25:12Z

    Java bug on windows.

commit 247c9b69aad53ba1f6346d75b5241fe4fdcd71cb
Author: U-FAREAST\tl <[email protected]>
Date:   2016-04-25T11:22:33Z

    fix windows issue

commit 47bf9163b2f225cb950d04c6a1b1d9c1ef859162
Author: U-FAREAST\tl <[email protected]>
Date:   2016-04-26T02:12:07Z

    Check symlink for win

commit 4ce9f18098c47b028cb19623fa2530ac6d9e5679
Author: Tao LI <[email protected]>
Date:   2016-05-03T02:35:27Z

    Fix style

commit 68a998986c0f564b9565543aeeb75f37a25589ce
Author: Tao LI <[email protected]>
Date:   2016-05-03T04:53:37Z

    Fix subject to PR comments

commit a9a205547834e685637d7dd9f8ae811d53ac948a
Author: U-FAREAST\tl <[email protected]>
Date:   2016-05-03T05:55:02Z

    Revert sparksubmit change

commit cbe5bd3757782ce7949204435203d9add78a5ad8
Author: U-FAREAST\tl <[email protected]>
Date:   2016-05-05T03:14:34Z

    Minor code cleanup

commit a96a87308c0175cea71151c99be56f3535e4052d
Author: Tao LI <[email protected]>
Date:   2016-05-05T03:45:54Z

    Fix path issue of SparkSubmitSuite on Linux

commit cafca626e6ac113c078657506c4283cadfaf91ed
Author: hyukjinkwon <[email protected]>
Date:   2016-09-30T14:51:45Z

    Do not fix the test already fixed

commit 610d6457b6d76430c5117bcb23f56c23d7fc48d9
Author: hyukjinkwon <[email protected]>
Date:   2016-10-01T06:28:42Z

    Improve comments

commit 1ff1d57c085af01bc1626d3980656baa0fd9852a
Author: hyukjinkwon <[email protected]>
Date:   2016-10-01T08:44:34Z

    Fix comments

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to