Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/15239#discussion_r81601610
--- Diff: R/pkg/R/generics.R ---
@@ -651,23 +651,25 @@ setGeneric("write.jdbc", function(x, url, tableName,
mode = "error", ...) {
#' @rdname write.json
#' @export
-setGeneric("write.json", function(x, path) { standardGeneric("write.json")
})
+setGeneric("write.json", function(x, path, mode = NULL, ...) {
standardGeneric("write.json") })
--- End diff --
would it be better as more generic to have these generics as
`setGeneric("write.json", function(x, path, ...)` instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
