Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15307#discussion_r81613977
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
 ---
    @@ -185,25 +203,36 @@ class StreamExecution(
           SparkSession.setActiveSession(sparkSession)
     
           triggerExecutor.execute(() => {
    -        if (isActive) {
    -          if (currentBatchId < 0) {
    -            // We'll do this initialization only once
    -            populateStartOffsets()
    -            logDebug(s"Stream running from $committedOffsets to 
$availableOffsets")
    -          } else {
    -            constructNextBatch()
    -          }
    -          if (dataAvailable) {
    -            runBatch()
    -            // We'll increase currentBatchId after we complete processing 
current batch's data
    -            currentBatchId += 1
    +        streamMetrics.reportTriggerStarted(currentBatchId)
    +        streamMetrics.reportTriggerInfo(STATUS_MESSAGE, "Finding new data 
from sources")
    +        val isTerminated = timeIt(TRIGGER_LATENCY) {
    +          if (isActive) {
    +            if (currentBatchId < 0) {
    +              // We'll do this initialization only once
    +              populateStartOffsets()
    +              logDebug(s"Stream running from $committedOffsets to 
$availableOffsets")
    +            } else {
    +              constructNextBatch()
    +            }
    +            if (dataAvailable) {
    +              streamMetrics.reportTriggerInfo(STATUS_MESSAGE, "Processing 
new data")
    +              streamMetrics.reportTriggerInfo(DATA_AVAILABLE, true)
    +              runBatch()
    +              // We'll increase currentBatchId after we complete 
processing current batch's data
    +              currentBatchId += 1
    +            } else {
    +              streamMetrics.reportTriggerInfo(STATUS_MESSAGE, "No new 
data")
    +              streamMetrics.reportTriggerInfo(DATA_AVAILABLE, false)
    +              Thread.sleep(100)
    --- End diff --
    
    Well it was hardcoded before. I can make it a SQLConf.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to