Github user erenavsarogullari commented on the issue:
https://github.com/apache/spark/pull/15326
Firstly, thanks @markhamstra and @kayousterhout for quick feedbacks.
I was aware of putting the check in `Pool.addSchedulable` to cover for all
`Schedulables` (`Pool` and `TaskSetManager` for now). My concern was that
`TaskSetManager` uses the following naming-pattern:
`var name = "TaskSet_" + taskSet.stageId.toString`
and if there is a case that a `stage` having multiple
TaskSet/TaskSetManager, this could be a problem. However, your comments already
clarified this so i agree moving to `Pool.addSchedulable` and adresses with
next commit ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
