Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/15307#discussion_r81873537
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -525,8 +645,62 @@ class StreamExecution(
case object TERMINATED extends State
}
-object StreamExecution {
+object StreamExecution extends Logging {
private val _nextId = new AtomicLong(0)
+ /**
+ * Get the number of input rows from the executed plan of the trigger
+ * @param triggerExecutionPlan Execution plan of the trigger
+ * @param triggerLogicalPlan Logical plan of the trigger, generated from
the query logical plan
+ * @param sourceToDataframe Source to DataFrame returned by the
source.getBatch in this trigger
+ */
+ def getNumInputRowsFromTrigger(
--- End diff --
Putting static methods in the object is not really a pattern we follow in
SQL (unless you need to use them elsewhere). Prefer `private` in the class to
avoid spreading the code out and for uniformity. If its only for testing, can
we not check the output from the listener?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
